https://bugzilla.redhat.com/show_bug.cgi?id=2400470

Ken Giusti <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(mikel@olasagasti.
                   |                            |info)



--- Comment #22 from Ken Giusti <[email protected]> ---
Hi Mikel just a quick update.  I've been trying to fix this review issue:

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Bad spec filename: /var/lib/copr-rpmbuild/results/go-fdo-
     server/srpm-unpacked/go-fdo-server.spec
     See: (this test has no URL)

I've looked into it a bit and I think this is a false negative: the check
CheckSpecAsInSRPM verifies that the spec filename "go-fdo-server.spec" matches
the prefix of the SRPM file
"go-fdo-server-0-0.1.20251021gita2d258a.fc44.src.rpm" which it obviously does.
So I put some debug tracing into the fedora-review tool and it turns out that
the test is incorrectly checking the *filename of Source0*, not the SRPM as
intended.  I've opened a bug against fedora-review for this:
https://pagure.io/FedoraReview/issue/534

For what it's worth selectively running just the CheckSpecAsInSRPM (e.g.
edora-review --single CheckSpecAsInSRPM --rpm-spec -n
tmp/go-fdo-server-0-0.1.20251021gita2d258a.fc44.src.rpm) passes as I would
expect.

What do you think? Can we ignore that warning?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2400470

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202400470%23c22

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to