https://bugzilla.redhat.com/show_bug.cgi?id=2418609
Petr Menšík <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected] | |om) --- Comment #2 from Petr Menšík <[email protected]> --- src/dnscap.h includes isc/list.h. Two files in isc/ directory are licensed under ISC license. If that is used to build the binary package and it seems so, License: tag has to contain it also. URL specified by the package does not work. Please set it either to codeberg source page or https://www.dns-oarc.net/tools/dnscap Instead, add separate variable for files, which can be reused in url. Although until we have only single file, using that url base in Source0 could be enough. %global files https://www.dns-oarc.net/files/%{name} ... Source0: %{files}/%{name}-%{version}.tar.gz I would put empty line after your %changelog entry, even if upstream has chosen to not include empty lines. rpmdev-bumpspec uses that and people will use in on Fedora package anyway. There is no %license marked file, that has to be fixed. Documentation should mark %doc files. It is not required to install them by make install. %doc directive will copy them into appropriate documentation directory for the package, ensures it keeps timestamp of original files. Instead of adding whole directory, we should add only separate files. %doc README.md CHANGES CONTRIBUTORS I would include CONTRIBUTORS only into devel subpackage. I doubt that is needed by dependencies using it only. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2418609 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418609%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
