https://bugzilla.redhat.com/show_bug.cgi?id=2418609
Jaroslav Škarvada <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #10 from Jaroslav Škarvada <[email protected]> --- Mostly LGTM, some more things spotted: > dnscap.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/dnscap/anonaes128.so /lib64/libbz2.so.1 > dnscap.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/dnscap/anonaes128.so /lib64/libz.so.1 > dnscap.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/dnscap/anonaes128.so /lib64/libcryptopANT.so.1 ... No need to add unused deps. Patch the used libtool or the Makefiles to drop the deps, i.e. move the "-Wl,--as-needed" before the "-lcrypto -lbz2 -lz -lcryptopANT -ldl -lpcap..." (and all used libs), not after it, otherwise unused deps are added. > Group: Productivity/Networking/DNS/Utilities RPM groups are obsoleted for a long time. > Source0: %{filesurl}/%{name}-%{version}.tar.gz If you aren't manipulating the specific sources or it's the only source file, no need to number it. > %if 0%{?suse_version} || 0%{?sle_version} If it isn't upstream SPEC directly re-used (e.g. in Packit automation) this could be probably dropped. > rm %{buildroot}/%{_docdir}/%{name}/LICENSE Maybe rather 'rm -f' to never ask (and block the script e.g. in case of some error) and ignore non-existent files. > * Tue Oct 21 2025 Jerry Lundström <[email protected]> 2.5.0-1 If it is based on some existing SPEC, it should be noted in the comment with the credit for the orignal SPEC and if the license of the original SPEC differs from the Fedora default SPEC license, it should be also noted. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2418609 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418609%23c10 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
