https://bugzilla.redhat.com/show_bug.cgi?id=2398039
Cristian Le <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(solomoncyj@gmail. | |com) --- Comment #46 from Cristian Le <[email protected]> --- Just a few minor notes, I will try to follow through and get this done within this year, needinfo me please. - Build failure: Afaict it is because 1. you are using shortcommit in `%global commitN` 2. the `mv` without `-T` is creating subfolders when instead you want to replace them. 3. you have the `mv` of Source11 and Source12 swapped around 4. you have a %{uuid} that is not expanded in %install I have made those changes locally and it built ok and I have gone ahead and reviewed the remaining parts based on those changes - Bundled packages versions are a bit off basing mostly on CMakeLists that I see at corresponding commits: - bundled(settings) should be 0.3.0 - bundled(serialize) should be 0.1.0 - bundled(magic_enum) should be 0.9.5 - bundled(certify) should be 0.1 - bundled(expected-lite) should be 0.9.0 - You seem to have left out the first line in the license breakdown (chatterino2: MIT AND BSD-3-Clause) Other than that it LGTM and I will approve it as soon as you get it working. Review based on applying the changes of the first item: --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/chatterino2 See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names (Fine, this is a retired package re-review) ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "BSD 3-Clause License", "*No copyright* MIT License", "*No copyright* Boost Software License 1.0", "Boost Software License 1.0", "*No copyright* Apache License 2.0", "MIT No Attribution", "OpenSSL License", "GNU Lesser General Public License, Version 3", "*No copyright* BSD 2-Clause License", "BSD 3-Clause License and/or JSON License and/or MIT License", "*No copyright* The Unlicense". 1871 files have unknown license. Detailed output of licensecheck in /home/cle/FedoraRPMs/2398039-chatterino2/srpm/review- chatterino2/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [?]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3231 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. (There are ctest provided, but running them seems more complex, fine to deffer for later investigation) [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: chatterino2-2.5.4^20251110gitf355928-1.20251110gitf355928.s20251216gitbb5417c.s20251216gitd847148.s20251216git4b12754.s20251216gitf4a7dbf.s20251216gite55b9b5.s20251216gita448a39.s20251216git6656728.fc44.x86_64.rpm chatterino2-2.5.4^20251110gitf355928-1.20251110gitf355928.s20251216gitbb5417c.s20251216gitd847148.s20251216git4b12754.s20251216gitf4a7dbf.s20251216gite55b9b5.s20251216gita448a39.s20251216git6656728.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7a4ghbb9')] checks: 32, packages: 2 chatterino2.src: E: spelling-error ('tv', '%description -l en_US tv -> TV, tb, t') chatterino2.x86_64: E: spelling-error ('tv', '%description -l en_US tv -> TV, tb, t') chatterino2.spec: W: specfile-warning warning: /tmp/rpmlint.chatterino2-2.5.4^20251110gitf355928-1.20251110gitf355928.s20251216gitbb5417c.s20251216gitd847148.s20251216git4b12754.s20251216gitf4a7dbf.s20251216gite55b9b5.s20251216gita448a39.s20251216git6656728.fc44.src.rpm.btekq8ur/chatterino2.spec line 153: autopatch: no matching patches in range chatterino2.x86_64: W: no-manual-page-for-binary chatterino chatterino2.x86_64: W: incoherent-version-in-changelog 2.5.4^20251110gitf355928-1 ['2.5.4^20251110gitf355928-1.20251110gitf355928.s20251216gitbb5417c.s20251216gitd847148.s20251216git4b12754.s20251216gitf4a7dbf.s20251216gite55b9b5.s20251216gita448a39.s20251216git6656728.fc44', '2.5.4^20251110gitf355928-1.20251110gitf355928.s20251216gitbb5417c.s20251216gitd847148.s20251216git4b12754.s20251216gitf4a7dbf.s20251216gite55b9b5.s20251216gita448a39.s20251216git6656728'] chatterino2.x86_64: W: files-duplicate /usr/share/licenses/chatterino2/expected-lite.txt /usr/share/licenses/chatterino2/boost_boost.txt chatterino2.x86_64: W: files-duplicate /usr/share/licenses/chatterino2/pajlada_signals.txt /usr/share/licenses/chatterino2/pajlada_settings.txt 2 packages and 0 specfiles checked; 2 errors, 5 warnings, 7 filtered, 2 badness; has taken 1.6 s Rpmlint (debuginfo) ------------------- Checking: chatterino2-debuginfo-2.5.4^20251110gitf355928-1.20251110gitf355928.s20251216gitbb5417c.s20251216gitd847148.s20251216git4b12754.s20251216gitf4a7dbf.s20251216gite55b9b5.s20251216gita448a39.s20251216git6656728.fc44.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpn81mjg30')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 16.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 chatterino2.x86_64: W: unused-direct-shlib-dependency /usr/bin/chatterino /lib64/libqt6keychain.so.1 chatterino2.x86_64: E: spelling-error ('tv', '%description -l en_US tv -> TV, tb, t') chatterino2.x86_64: W: no-manual-page-for-binary chatterino chatterino2.x86_64: W: incoherent-version-in-changelog 2.5.4^20251110gitf355928-1 ['2.5.4^20251110gitf355928-1.20251110gitf355928.s20251216gitbb5417c.s20251216gitd847148.s20251216git4b12754.s20251216gitf4a7dbf.s20251216gite55b9b5.s20251216gita448a39.s20251216git6656728.fc44', '2.5.4^20251110gitf355928-1.20251110gitf355928.s20251216gitbb5417c.s20251216gitd847148.s20251216git4b12754.s20251216gitf4a7dbf.s20251216gite55b9b5.s20251216gita448a39.s20251216git6656728'] chatterino2.x86_64: W: files-duplicate /usr/share/licenses/chatterino2/expected-lite.txt /usr/share/licenses/chatterino2/boost_boost.txt chatterino2.x86_64: W: files-duplicate /usr/share/licenses/chatterino2/pajlada_signals.txt /usr/share/licenses/chatterino2/pajlada_settings.txt 2 packages and 0 specfiles checked; 1 errors, 5 warnings, 9 filtered, 1 badness; has taken 0.9 s Source checksums ---------------- https://github.com/Chatterino/chatterino2/archive/f3559280786dbabc8cebe1951a525580d11cb2a5/chatterino2-f3559280786dbabc8cebe1951a525580d11cb2a5.tar.gz : CHECKSUM(SHA256) this package : c4196bf48747144cca0636478c9239216adcb55bd1a83402b7bf2e24ac7a0235 CHECKSUM(SHA256) upstream package : c4196bf48747144cca0636478c9239216adcb55bd1a83402b7bf2e24ac7a0235 https://github.com/hemirt/libcommuni/archive/bb5417c451d764f57f2f1b3e1c9a81496b5521bd/libcommuni-bb5417c451d764f57f2f1b3e1c9a81496b5521bd.tar.gz : CHECKSUM(SHA256) this package : b5536c414394a18e6a6671c86d702477d0174e5b111b5abe86a20166275cd1af CHECKSUM(SHA256) upstream package : b5536c414394a18e6a6671c86d702477d0174e5b111b5abe86a20166275cd1af https://github.com/pajlada/settings/archive/d847148cbf0becb75e48b90c2c25b78922f4e181/settings-d847148cbf0becb75e48b90c2c25b78922f4e181.tar.gz : CHECKSUM(SHA256) this package : a891190c6449f99e23b8820ee758fa7489c04e8deae4b78d27b6d0289c22a9b5 CHECKSUM(SHA256) upstream package : a891190c6449f99e23b8820ee758fa7489c04e8deae4b78d27b6d0289c22a9b5 https://github.com/pajlada/signals/archive/4b127541d30d9ae86df1553cb567cc2fc55fac46/signals-4b127541d30d9ae86df1553cb567cc2fc55fac46.tar.gz : CHECKSUM(SHA256) this package : 0509be0047397086d4d2e33ad0fabf38664657a6150a521e3ae58cae4c003f9a CHECKSUM(SHA256) upstream package : 0509be0047397086d4d2e33ad0fabf38664657a6150a521e3ae58cae4c003f9a https://github.com/pajlada/serialize/archive/f4a7dbfa64e7515506bdb75f6037cb74cd37f67c/serialize-f4a7dbfa64e7515506bdb75f6037cb74cd37f67c.tar.gz : CHECKSUM(SHA256) this package : f8c5aaf9f21cc366f4a5f12f0ff5a80091fcc4b6e1665fa7fb5b42e8323255b4 CHECKSUM(SHA256) upstream package : f8c5aaf9f21cc366f4a5f12f0ff5a80091fcc4b6e1665fa7fb5b42e8323255b4 https://github.com/Neargye/magic_enum/archive/e55b9b54d5cf61f8e117cafb17846d7d742dd3b4/magic_enum-e55b9b54d5cf61f8e117cafb17846d7d742dd3b4.tar.gz : CHECKSUM(SHA256) this package : bdb15ee58b44988a493b514194ca7e770b7c69d8af0c93d4447bcfa5fc044e3a CHECKSUM(SHA256) upstream package : bdb15ee58b44988a493b514194ca7e770b7c69d8af0c93d4447bcfa5fc044e3a https://github.com/djarek/certify/archive/a448a3915ddac716ce76e4b8cbf0e7f4153ed1e2/certify-a448a3915ddac716ce76e4b8cbf0e7f4153ed1e2.tar.gz : CHECKSUM(SHA256) this package : cd9ea0390ec39b75b16ba9f59486d8d42501a3444a045fa2ace016e8eba8d6e1 CHECKSUM(SHA256) upstream package : cd9ea0390ec39b75b16ba9f59486d8d42501a3444a045fa2ace016e8eba8d6e1 https://github.com/martinmoene/expected-lite/archive/6656728c5874fefa976ff7c67999798df7fc961d/expected-lite-6656728c5874fefa976ff7c67999798df7fc961d.tar.gz : CHECKSUM(SHA256) this package : fbba6213c2bfdbcb0ee1535159621892a3a91672fd3389bd3ed33ffb6da2a9ac CHECKSUM(SHA256) upstream package : fbba6213c2bfdbcb0ee1535159621892a3a91672fd3389bd3ed33ffb6da2a9ac Requires -------- chatterino2 (rpmlib, GLIBC filtered): hicolor-icon-theme libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.10)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Network.so.6()(64bit) libQt6Network.so.6(Qt_6)(64bit) libQt6Svg.so.6()(64bit) libQt6Svg.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_4.3.0)(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libm.so.6()(64bit) libnotify.so.4()(64bit) libqt6keychain.so.1()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) Provides -------- chatterino2: application() application(com.chatterino.chatterino.desktop) bundled(certify) bundled(expected-lite) bundled(libcommuni) bundled(magic_enum) bundled(serialize) bundled(settings) bundled(signals) chatterino2 chatterino2(x86-64) metainfo() metainfo(com.chatterino.chatterino.appdata.xml) Diff spec file in url and in SRPM --------------------------------- --- /home/cle/FedoraRPMs/2398039-chatterino2/srpm/chatterino2.spec 2025-12-16 13:39:57.597179355 +0700 +++ /home/cle/FedoraRPMs/2398039-chatterino2/srpm/review-chatterino2/srpm-unpacked/chatterino2.spec 2025-12-16 07:00:00.000000000 +0700 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval ExcludeArch: %{ix86} @@ -187,3 +197,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Tue Dec 16 2025 John Doe <[email protected]> - 2.5.4^20251110gitf355928-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review --name chatterino2 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Python, Ocaml, Haskell, Java, PHP, fonts, R, SugarActivity, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2398039 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202398039%23c46 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
