https://bugzilla.redhat.com/show_bug.cgi?id=2398039
--- Comment #43 from Cristian Le <[email protected]> --- Seems like I mislead you with the improvements suggestion. I did a bit of local debugging and here is what I have: - Looks like you still need the full commit hash because internally github still uses the full commit hash in the folder name. So I guess you can revert this part. You could also use `%forgeversion -z <n>` and let it fill in all the stuff there - The mv command there would make a subfolder under it. Use `mv -T` to overwrite the folders - `%forgesetup -a` is broken due to the order in which they are processed, but surprisingly, you can call `%forge(auto)setup -z 0` after the `%forgesetup -a` and it works. The manual `%setup` before is also fine, it just that it requires keeping track of the forgemeta urls, but you can sol do it like this ``` %prep %forgesetup -a %forgeautosetup -z0 -p1 mv -T %{_builddir}/%{extractdir2} lib/libcommuni mv -T %{_builddir}/%{extractdir3} lib/settings mv -T %{_builddir}/%{extractdir4} lib/signals mv -T %{_builddir}/%{extractdir5} lib/serialize mv -T %{_builddir}/%{extractdir9} lib/magic_enum mv -T %{_builddir}/%{extractdir11} lib/certify mv -T %{_builddir}/%{extractdir12} lib/expected-lite ``` - You still have a reference to `%{uuid}` in the `%check` section, and a few other glob patterns. I am fine with the `uuid` macro btw, it's just the glob patterns that could hide some issues down the line. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2398039 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202398039%23c43 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
