https://bugzilla.redhat.com/show_bug.cgi?id=2432458
Bug ID: 2432458
Summary: Review Request: gstr - Single-header UTF-8 grapheme
string library for C
Product: Fedora
Version: rawhide
Hardware: x86_64
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected]
Target Milestone: ---
Classification: Fedora
Spec URL:
https://download.copr.fedorainfracloud.org/results/edwardjedmonds/gstr/fedora-rawhide-x86_64/10050975-gstr/gstr.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/edwardjedmonds/gstr/fedora-rawhide-x86_64/10050975-gstr/gstr-2.0.2-1.fc44.src.rpm
Description: gstr is a single-header UTF-8 string library for C providing
grapheme-aware functions that operate on what users perceive as characters, not
bytes. Handles emoji, CJK, combining marks, and all Unicode correctly. 60
functions across UTF-8 and grapheme layers. Zero dependencies.
Fedora Account: edwardjedmonds
COPR: https://copr.fedorainfracloud.org/coprs/edwardjedmonds/gstr/
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Spec URL: https://copr.fedorainfracloud.org/coprs/edwardjedmonds/gstr/
SRPM URL: https://copr.fedorainfracloud.org/coprs/edwardjedmonds/gstr/
Description: gstr is a single-header UTF-8 string library for C providing
grapheme-aware functions that operate on what users perceive as characters,
not bytes. Handles emoji, CJK, combining marks, and all Unicode correctly.
===== MUST items =====
C/C++:
[x]: Header files in -devel subpackage, if present.
VERIFIED: gstr.h is in gstr-devel subpackage.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
VERIFIED: MIT license is OSI-approved and Fedora-allowed.
[x]: License field in the package spec file matches the actual license.
VERIFIED: All source files contain SPDX-License-Identifier: MIT headers.
licensecheck confirms MIT License for all files.
[x]: Package contains no bundled libraries or specifies bundled libraries
with Provides: bundled(<libname>) if unbundling is not possible.
VERIFIED: No bundled libraries. gstr.h is original code implementing
Unicode grapheme segmentation per UAX #29.
[x]: Changelog in prescribed format.
VERIFIED: Changelog follows "* Day Mon DD YYYY Name <email> - version"
format.
[x]: Sources contain only permissible code or content.
VERIFIED: Original code by maintainer, MIT licensed.
[-]: Package contains desktop file if it is a GUI application.
NOT APPLICABLE: This is a C library, not a GUI application.
[x]: Development files must be in a -devel package
VERIFIED: Header file is in gstr-devel subpackage.
[x]: Package uses nothing in %doc for runtime.
VERIFIED: README.md is documentation only, not required at runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
VERIFIED: Uses %{_includedir}, %{buildroot}, etc.
[x]: Package is named according to the Package Naming Guidelines.
VERIFIED: "gstr" follows naming conventions (lowercase, no special chars).
[x]: Package does not generate any conflict.
VERIFIED: No Conflicts: tag, package name is unique.
[x]: Package obeys FHS, except libexecdir and /usr/target.
VERIFIED: Installs only to /usr/include (standard location for headers).
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
NOT APPLICABLE: This is a new package, not a rename.
[x]: Requires correct, justified where necessary.
VERIFIED: No runtime Requires needed (header-only library).
[x]: Spec file is legible and written in American English.
VERIFIED: Spec is clear and uses American English.
[-]: Package contains systemd file(s) if in need.
NOT APPLICABLE: Library package, no daemons/services.
[x]: Package is not known to require an ExcludeArch tag.
VERIFIED: Header-only library is architecture-independent (noarch).
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
VERIFIED: Documentation is only 28KB (README.md), well under 1MB
threshold.
[x]: Package complies to the Packaging Guidelines
VERIFIED: Follows all applicable guidelines for header-only C libraries.
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: All rpmlint "errors" are spelling complaints about function names
(gstrlen, gstrcmp, etc.) which are intentional technical terms.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
VERIFIED: LICENSE file is included upstream. All source files have SPDX
headers.
[x]: Final provides and requires are sane (see attachments).
VERIFIED: Provides gstr-devel and gstr-static. No unusual Requires.
[x]: Package functions as described.
VERIFIED: Tests pass in %check section. Library provides UTF-8 grapheme
string operations as documented.
[x]: Latest version is packaged.
VERIFIED: 2.0.2 is the latest release on GitHub.
[x]: Package does not include license text files separate from upstream.
VERIFIED: Uses upstream LICENSE file directly.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
NOT APPLICABLE: Upstream does not publish GPG signatures for releases.
[x]: Package should compile and build into binary rpms on all supported
architectures.
VERIFIED: noarch package, architecture-independent.
[x]: %check is present and all tests pass.
VERIFIED: %check runs test_gstr which passes.
[x]: Packages should try to preserve timestamps of original installed
files.
VERIFIED: install -p flag used in %install section.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: All rpmlint "errors" are spelling complaints about function names
(gstrlen, gstrcmp, grapheme, etc.) which are intentional technical terms,
not actual spelling mistakes.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: gstr-devel-2.0.2-1.fc44.noarch.rpm
gstr-2.0.2-1.fc44.src.rpm
All 52 rpmlint "spelling errors" are function names (gstrlen, gstrcmp, gstrcat,
utf8_cpwidth, etc.) and technical terms (grapheme). These are intentional API
names, not spelling mistakes.
No actual issues found.
Source checksums
----------------
https://github.com/edwardedmonds/gstr/archive/v2.0.2/gstr-2.0.2.tar.gz :
CHECKSUM(SHA256) this package :
c3312dcc4a5b5c785c09985fc9e19d6311bdc7ec8903fe0216b062f356204754
CHECKSUM(SHA256) upstream package :
c3312dcc4a5b5c785c09985fc9e19d6311bdc7ec8903fe0216b062f356204754
Requires
--------
gstr-devel (rpmlib, GLIBC filtered):
(no runtime requires - header-only library)
Provides
--------
gstr-devel:
gstr-devel
gstr-static
Generated by fedora-review 0.11.0
Buildroot used: fedora-rawhide-x86_64
Reproducible: Always
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2432458
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432458%23c0
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
