https://bugzilla.redhat.com/show_bug.cgi?id=2439304
Steve Cossette <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Steve Cossette <[email protected]> --- I'm thinking of taking this review. I can see a couple issues though: 1- Some places in your spec you account for "if" upstream ever makes a release with how the project version shows, and some places you don't. For example: Release: %autorelease -s %{date}git%{shortcommit} %autosetup -p1 -n %{name}-%{commit} (If/when the project makes an official release, those wont work) 2- The license "ASL 2.0" is the legacy naming and should be changed. See: https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ for the SPDX expression. 3- `%{_libdir}/cmake/GKlib/` should be in the devel subpackage 4- The Apache 2.0 license is not applied properly and most likely wouldn't be allowed in fedora as-is. They only put the header inside the LICENSE.txt, while that should go in the source file headers. The Apache 2.0 license itself should be in the LICENSE.txt, along with, optionally, a NOTICE file pointing to it. As-is, the Apache 2.0 license is not enforced. So this is a big no-no and should get fixed upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2439304 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202439304%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
