https://bugzilla.redhat.com/show_bug.cgi?id=2439304
--- Comment #4 from Antonio T. sagitter <[email protected]> --- (In reply to Cristian Le from comment #3) > Hi Steve, I was around the discussions of the project and if you take it, > just want to point out a few major points that I want to raise about this: ... > - Upstream is quite unresponsive and there were multiple forks and attempts > to help [2-4]. I would suggest to have a copr repo to review that this and > the metis update are actually compatible with each other > ... > - The `PCRE_LDFLAGS=-lpcreposix` is very suspicious. Please elaborate on it. > - `%undefine _ld_as_needed` is also suspicious > - Please abstract the soversion in a variable > > [1]: https://github.com/KarypisLab/GKlib/issues/30 > [2]: https://github.com/KarypisLab/GKlib/pull/34 > [3]: https://github.com/KarypisLab/GKlib/pull/33 > [4]: https://github.com/KarypisLab/GKlib/pull/28 > [5]: example on my package > https://src.fedoraproject.org/rpms/span/blob/rawhide/f/span.spec Hi Cristian Hi Steve I think that, excepting all that is closely concerning to the packaging, these issues should be discussed/resolved with upstream. All i want to do here is to make as best as possible the RPM of the code actually distributed. I can't supersede upstream developers. @Cristian > [1]: https://github.com/KarypisLab/GKlib/issues/30 > [2]: https://github.com/KarypisLab/GKlib/pull/34 > [3]: https://github.com/KarypisLab/GKlib/pull/33 > [4]: https://github.com/KarypisLab/GKlib/pull/28 I did not understand if your changes have been already partially merged by upstream. > Likely upstream should do a `find_package(PCRE)` instead and specify if they > want PCRE2 `find_package(PCRE)` requires a PCRE CMake config file that does not exist; or am i wrong? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2439304 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202439304%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
