https://bugzilla.redhat.com/show_bug.cgi?id=2417806
--- Comment #17 from Peter Oliver <[email protected]> --- You should have a %check section in which you run test.pl. (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites) Many of the tests will fail unless some external command is installed, so you'll need to add those to BuildRequires. The remainder of the tests will be skipped unless some external command is installed. You should add those to BuildRequires if they're packaged for Fedora/EPEL (with the Fedora-only ones, if any, in an %if block). It could be argued that the package should Recommend all of those things too, but that feels like it might be too much to me. The /etc/profile.d/less.sh and less.csh provided by the less package only modify the LESSOPEN environment variable if it is not already set. I think this package should do the same. On EPEL, so that this lesspipe takes precedence over the less package's lesspipe, I would suggest doing this in files called, say, /etc/profile.d/50-lesspipe.sh and 50-lesspipe.csh, so that they run first. For the vimcolor script to work, we need: Requires: (vim-enhanced or neovim) However, vimcolor is only tried if none of the commands nvimpager, bat, batcat, pygmentize, source-highlight, are installed. Further, code2color is only tried if none of those and vim or nvim installed. Perhaps it makes sense to split each of vimcolor and code2color out into separate subpackages, then Recommend one of any of the colourizers, Suggesting whichever one we feel is best/smallest/least intrusive/highest precedence/whatever: Recommends: (bat or pygmentize or source-highlight or vimcolor or code2color) Suggests: bat (I don't know if bat is actually a good choice; this is just an example) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2417806 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202417806%23c17 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
