https://bugzilla.redhat.com/show_bug.cgi?id=2030050



--- Comment #14 from Jaroslav Škarvada <[email protected]> ---
(In reply to Antonio T. sagitter from comment #13)
Thanks for the review.

> - See "Diff spec file in url and in SRPM" at the bottom
This is bug of the fedora review tool, it doesn't recognize %autochangelog and
reports this false positive.

> - Please, number he patched in the form PatchN
Why to return to this old format? Patch is described in the comment and
automatically applied in order by the %autosetup. Why to complicate it with
maintenance of some sequential numbers which aren't used anywhere?

> - Note this message:
> 
> ```
>   /usr/lib/python3.14/site-packages/setuptools/dist.py:599:
> SetuptoolsDeprecationWarning:
>   Invalid dash-separated key 'description-file' in 'metadata' (setup.cfg),
> please use the underscore name 'description_file' instead.
>   !!
>          
> *****************************************************************************
> ***
>           Usage of dash-separated 'description-file' will not be supported
> in future
>           versions. Please use the underscore name 'description_file'
> instead.
>           (Affected: TinySASaver).
>           Available configuration options are listed in:
>          
> https://setuptools.pypa.io/en/latest/userguide/declarative_config.html
>           By 2026-Mar-03, you need to update your project and remove
> deprecated calls
>           or your builds will no longer be supported.
>           See https://github.com/pypa/setuptools/discussions/5011 for
> details.
>          
> *****************************************************************************
> ***
>   !!
>     opt = self._enforce_underscore(opt, section)
> ```
> 
I will notify upstream.

> - LICENSE should be added automatically, so you dont need to list in %files
>
Fixed.

Spec URL: https://jskarvad.fedorapeople.org/tinysa/tinysa-saver.spec
SRPM URL:
https://jskarvad.fedorapeople.org/tinysa/tinysa-saver-0.11-1.fc45.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2030050

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202030050%23c14

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to