https://bugzilla.redhat.com/show_bug.cgi?id=2030050



--- Comment #16 from Jaroslav Škarvada <[email protected]> ---
(In reply to Antonio T. sagitter from comment #15)
> >> - Please, number he patched in the form PatchN
> > Why to return to this old format? Patch is described in the comment and 
> > automatically applied in order by the %autosetup. Why to complicate it with 
> > maintenance of some sequential numbers which 
> > aren't used anywhere?
> 
> It is not mandatory but advisable:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_applying_patches
> 
I guess the guide wasn't updated, because I don't see any technical reason why
to enforce here the sequential numbers. If there are multiple patches that are
updated/deleted/added during the package lifetime, the series can very quickly
become a fragmented mess. So it is either fragmented or if manually
defragmented it complicates backports. Explicit patch numbers can help if you
e.g. need to conditionally apply patches, but it isn't this case.

> Executable is not running on Fedora 43:
> 
> $ /usr/bin/TinySASaver
> Traceback (most recent call last):
>   File "/usr/bin/TinySASaver", line 5, in <module>
>     from TinySASaver.__main__ import main
>   File "/usr/lib/python3.14/site-packages/TinySASaver/__main__.py", line 22,
> in <module>
>     from .TinySASaver import TinySASaver
>   File "/usr/lib/python3.14/site-packages/TinySASaver/TinySASaver.py", line
> 36, in <module>
>     from .Calibration import CalibrationWindow, Calibration
>   File "/usr/lib/python3.14/site-packages/TinySASaver/Calibration.py", line
> 815, in <module>
>     class Calibration:
>     ...<273 lines>...
>                 logger.exception("Failed loading calibration data: %s", e)
>   File "/usr/lib/python3.14/site-packages/TinySASaver/Calibration.py", line
> 834, in Calibration
>     shortIdeal = np.complex(-1, 0)
>                  ^^^^^^^^^^
>   File "/usr/lib64/python3.14/site-packages/numpy/__init__.py", line 778, in
> __getattr__
>     raise AttributeError(__former_attrs__[attr], name=None)
> AttributeError: module 'numpy' has no attribute 'complex'.
> `np.complex` was a deprecated alias for the builtin `complex`. To avoid this
> error in existing code, use `complex` by itself. Doing this will not modify
> any behavior and is safe. If you specifically wanted the numpy scalar type,
> use `np.complex128` here.
> The aliases was originally deprecated in NumPy 1.20; for more details and
> guidance see the original release note at:
>     https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

I will check it, I will have access to the tinySA HW soon.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2030050

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202030050%23c16

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to