https://bugzilla.redhat.com/show_bug.cgi?id=2453288
Tyler Fanelli <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(code@musicinmybra | |in.net) --- Comment #13 from Tyler Fanelli <[email protected]> --- (In reply to Ben Beasley from comment #7) > Hmm, the basic idea here looks reasonable, and the packaged static library > seems to be correctly handled and adequatedly justified, but something is > weird about the shared library. The fedora-review program complains that > it’s statically linked, and "file > rpms-unpacked/libnsm-0.5.1-2.fc45.x86_64.rpm/usr/lib64/libnsm.so.0.5.1" > gives > "rpms-unpacked/libnsm-0.5.1-2.fc45.x86_64.rpm/usr/lib64/libnsm.so.0.5.1: ELF > 64-bit LSB pie executable, x86-64, version 1 (SYSV), statically linked, > BuildID[sha1]=0ba89214768e51781e4ba9331cbb8f3311dce22b, stripped", where a > more typical shared library might look like > "/usr/lib64/libz.so.1.3.1.zlib-ng: ELF 64-bit LSB shared object, x86-64, > version 1 (SYSV), dynamically linked, > BuildID[sha1]=c03522d8b3fa0325563dfbddbf7564d9f02d60ef, stripped". I thought > this might have to do with the STATIC=1 Makefile variable, but I can’t seem > to tell what that actually does, and rebuilding without it doesn’t seem to > make any difference. > > Any chance you’re able to explain to me what I’m looking at? I've tried reproducing this locally. When examining the installed file: $ file /usr/local/lib/libnsm.so.0.5.1 /usr/local/lib/libnsm.so.0.5.1: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=0d736fdabec2f6f2710e6a58c4042bee007c953a, not stripped The only difference between this and your example, is "stripped" vs "not stripped". Is that relevant at all? Furthermore, it seems the build system may be doing something behind the scenes? I followed the install process as it's shown in the spec file, and cannot reproduce locally. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2453288 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202453288%23c13 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
