https://bugzilla.redhat.com/show_bug.cgi?id=2468312



--- Comment #24 from Cristian Le <[email protected]> ---
Do not worry about the fedora review output, this is to be used by the reviewer
primarily, and I went over it and selected the parts that are relevant
previously. It has quite a few known false-positives (or negatives?).

Do run it though with that command whenever you make changes so that it can
produce a diff and notify me that there are changes.

> Large data in /usr/share - I presume this means we should have a noarch 
> subpackage for those. I will investigate this.

This is because of the pdf generated docs, I guess another reason why they are
not encouraged. You can either drop the pdf formats, or move them into a `doc`
subpackage.

Please ping me when you are ready for me to look at this again or if you have
questions


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2468312

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202468312%23c24

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to