https://bugzilla.redhat.com/show_bug.cgi?id=2468312
--- Comment #27 from Cristian Le <[email protected]> --- > The big one is help files. I have moved those into -help noarch subpackage. Please no, that is not according to guidelines. The guidelines is to have `doc` subpackage [1] if it is necessary. Looking at the files in help, they are all just zip archives of the site https://pwsafe.org/, but in an un-navigable format as these are just snippets without a main `index.html` to glue them into a single page. My suggestion would be to drop these. The alternative of `doc` subpackage is also acceptable. > password safe help/about contains a link to check for the latest version Thanks for pointing it out. The text is not ideal, but it is not a blocker for the review either (it does not actively bypass the packaging), it looks like a good check to have overall. Open the discussion to make this editable, it does not look hard to do so [2]. My recommendation is something along the lines "You can try to update with [insert update command], or suggest an update at [insert src.fp.o link here]" [1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation [2]: https://github.com/pwsafe/pwsafe/blob/a8825d431e38817ecf2a9c9912f623be9f2c4818/src/ui/wxWidgets/AboutDlg.cpp#L538-L549 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2468312 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202468312%23c27 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
