https://bugzilla.redhat.com/show_bug.cgi?id=2437502
--- Comment #287 from Nicola Taibi <[email protected]> --- ubject: Updated Submission: SpaceGL RPM Packaging Review Dear Reviewer, Thank you for your constructive feedback regarding the SpaceGL package. I have implemented the requested changes, and the package now fully aligns with the packaging guidelines. Please find the summary of the adjustments below: * Cleanup: I have removed the unused autorelease_version macro and the %check section as requested. * Dependency Management: I have refactored the BuildRequires to utilize the pkgconfig() style for improved cross-platform reliability. * Wrapper Scripts and Documentation: The .sh extension has been removed from all binaries installed in /usr/bin/. I have updated the build system (CMakeLists.txt) and the RPM spec file to natively install these as spacegl-server, spacegl-client, and spacegl-diag. I have also updated the corresponding manual pages and the project’s documentation (README.md and README_it.md) to reflect these changes accurately. * Binary Stripping: I have restored the standard global stripping behavior for the entire package. To address the functional requirement for spacegl_diag, I have configured the build to granularly exclude this specific binary from the automated stripping process. As detailed in issue #155, the spacegl_diag tool requires the original debug symbols to correctly resolve the Shared Memory (SHM) layout at runtime; stripping them would result in a functional regression. This is achieved via a modification to the __os_install_post macro to selectively exclude the file, ensuring the remainder of the software follows standard distribution policies. I believe these changes effectively address your concerns while preserving the necessary operational integrity of the software. Thank you again for your time and professional guidance in this review process. Best regards, Nicola Taibi Fedora 44: Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-44-x86_64/10511486-spacegl/spacegl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-44-x86_64/10511486-spacegl/spacegl-2026.05.26.01-1.fc44.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2437502 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437502%23c287 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
