https://bugzilla.redhat.com/show_bug.cgi?id=2437502



--- Comment #295 from Nicola Taibi <[email protected]> ---
(In reply to Fabio Porcedda from comment #294)
> Hi,
> issue found:
> - Please remove the leftover comment about stripping
> - Please remove the license.txt from data because is already in the base
> package
> - Please use just /usr/share/doc/spacegl instead of
> /usr/share/doc/spacegl-data/ and /usr/share/doc/spacegl-doc/
> - Please fix HOWTO.txt becuase it still refers to .sh files

Subject: Re: Package Review Request: spacegl - Space exploration and combat
game engine

Hi,

Thank you for your time and for the constructive feedback on the package. 

I have implemented the requested changes to address all the points you raised.
Specifically:

1. **Leftover comments:** I have removed the outdated comment regarding binary
stripping from the `.spec` file.
2. **License duplication:** I have removed the `LICENSE.txt` file from the
`data` subpackage, since it is already provided by the base package.
3. **Documentation directory unification:** I have consolidated the
documentation paths by setting `%global _docdir_fmt %{name}` in the spec file.
All documentation is now correctly installed directly under
`/usr/share/doc/spacegl`, bypassing the separate `spacegl-data` and
`spacegl-doc` folders.
4. **HOWTO.txt corrections:** I have updated `HOWTO.txt` to remove all outdated
references to `.sh` script extensions for the executables.

These changes have been committed upstream, the changelog has been updated, and
the package version has been bumped to **2026.05.30.01**. The updated SPEC and
SRPM files are now available.

Please let me know if there are any further adjustments required to proceed
with the approval process.

Best regards,
Nicola Taibi

Fedora 44:
  Spec URL: 
https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-44-x86_64/10526710-spacegl/spacegl.spec

  SRPM URL: 
https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-44-x86_64/10526710-spacegl/spacegl-2026.05.30.01-1.fc44.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2437502

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437502%23c295

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to