https://bugzilla.redhat.com/show_bug.cgi?id=2481488



--- Comment #2 from Jitka Plesnikova <[email protected]> ---
Source file is ok
Summary is ok
License:
FIX: The license should be Artistic-2.0. It is mention in
     lib/Text/JSCalendar.pm and lib/Text/JSCalendar/TimeZones.pm

Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add build-requires
     perl(Carp) - lib/Text/JSCalendar.pm:6
     perl(Data::Dumper) - lib/Text/JSCalendar.pm:22
     perl(Data::ICal) - lib/Text/JSCalendar.pm:7
     perl(Data::ICal::Entry::Alarm::Display) - lib/Text/JSCalendar.pm:11
     perl(Data::ICal::Entry::Alarm::Email) - lib/Text/JSCalendar.pm:10
     perl(Data::ICal::Entry::Event) - lib/Text/JSCalendar.pm:8
     perl(Data::ICal::Entry::TimeZone) - lib/Text/JSCalendar/TimeZones.pm:22
     perl(Data::ICal::Entry::TimeZone::Daylight) -
lib/Text/JSCalendar/TimeZones.pm:23
     perl(Data::ICal::Entry::TimeZone::Standard) -
lib/Text/JSCalendar/TimeZones.pm:24
     perl(MIME::Base64) - lib/Text/JSCalendar.pm:18
     perl(URI::Escape) - lib/Text/JSCalendar.pm:21
     perl(HTTP::Request) - t/cyrus-caldav.t:8
     perl(lib) - t/cyrus-caldav.t:10

$ rpm -qp --requires perl-Text-JSCalendar-0.05-1.fc45.noarch.rpm | sort | uniq
-c | grep -v rpmlib
      1 perl(Carp)
      1 perl(Data::Dumper)
      1 perl(Data::ICal)
      1 perl(Data::ICal::Entry::Alarm::Display)
      1 perl(Data::ICal::Entry::Alarm::Email)
      1 perl(Data::ICal::Entry::Event)
      1 perl(Data::ICal::Entry::TimeZone)
      1 perl(Data::ICal::Entry::TimeZone::Daylight)
      1 perl(Data::ICal::Entry::TimeZone::Standard)
      1 perl(Data::ICal::TimeZone) >= 1.23
      1 perl(DateTime::Format::ICal) >= 0.09
      1 perl(DateTime::Format::ISO8601) >= 0.08
      1 perl(DateTime::TimeZone)
      1 perl(Digest::SHA)
      1 perl(JSON)
      1 perl(JSON::XS)
      1 perl-libs
      1 perl(MIME::Base64)
      1 perl(MIME::Types)
      1 perl(strict)
      1 perl(Text::JSCalendar::TimeZones)
      1 perl(Text::LevenshteinXS) >= 0.03
      1 perl(Text::VCardFast) >= 0.06
      1 perl(URI::Escape)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Text-JSCalendar-0.05-1.fc45.noarch.rpm | sort | uniq
-c
      1 perl(Text::JSCalendar) = 0.05
      1 perl-Text-JSCalendar = 0.05-1.fc45
      1 perl(Text::JSCalendar::TimeZones)
Binary provides are Ok.

$ rpmlint ./perl-Text-JSCalendar*
============================ rpmlint session starts
============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

perl-Text-JSCalendar.noarch: E: spelling-error ('iCalendar', 'Summary(en_US)
iCalendar -> i Calendar, calendar, Carbondale')
perl-Text-JSCalendar.noarch: E: spelling-error ('iCalendar', '%description -l
en_US iCalendar -> i Calendar, calendar, Carbondale')
perl-Text-JSCalendar.noarch: E: spelling-error ('ietf', '%description -l en_US
ietf -> diet')
perl-Text-JSCalendar.noarch: E: spelling-error ('calext', '%description -l
en_US calext -> cal ext, cal-ext, lexical')
perl-Text-JSCalendar.noarch: E: spelling-error ('icalendar', '%description -l
en_US icalendar -> calendar, i calendar, legendarily')
perl-Text-JSCalendar.noarch: E: spelling-error ('jscalendarbis', '%description
-l en_US jscalendarbis -> legendarily')
perl-Text-JSCalendar.noarch: E: spelling-error ('iCal', '%description -l en_US
iCal -> i Cal, Cal, Cali')
perl-Text-JSCalendar.src: E: spelling-error ('iCalendar', 'Summary(en_US)
iCalendar -> i Calendar, calendar, Carbondale')
perl-Text-JSCalendar.src: E: spelling-error ('iCalendar', '%description -l
en_US iCalendar -> i Calendar, calendar, Carbondale')
perl-Text-JSCalendar.src: E: spelling-error ('ietf', '%description -l en_US
ietf -> diet')
perl-Text-JSCalendar.src: E: spelling-error ('calext', '%description -l en_US
calext -> cal ext, cal-ext, lexical')
perl-Text-JSCalendar.src: E: spelling-error ('icalendar', '%description -l
en_US icalendar -> calendar, i calendar, legendarily')
perl-Text-JSCalendar.src: E: spelling-error ('jscalendarbis', '%description -l
en_US jscalendarbis -> legendarily')
perl-Text-JSCalendar.src: E: spelling-error ('iCal', '%description -l en_US
iCal -> i Cal, Cal, Cali')
 2 packages and 1 specfiles checked; 14 errors, 0 warnings, 8 filtered, 14
badness; has taken 0.5 s
Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items and provide a new spec file.

Resolution:
NOT Approved


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2481488

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202481488%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to