https://bugzilla.redhat.com/show_bug.cgi?id=2481488

Jitka Plesnikova <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #6 from Jitka Plesnikova <[email protected]> ---
> License:
> FIX: The license should be Artistic-2.0. It is mention in
>      lib/Text/JSCalendar.pm and lib/Text/JSCalendar/TimeZones.pm
@@ -4,3 +4,3 @@
 Summary:        Convert between iCalendar and JSCalendar
-License:        GPL-1.0-or-later OR Artistic-1.0-Perl
+License:        Artistic-2.0
 URL:            https://metacpan.org/dist/Text-JSCalendar
Ok

> BuildRequires
> FIX: Please add build-requires
>      perl(Carp) - lib/Text/JSCalendar.pm:6
>      perl(Data::Dumper) - lib/Text/JSCalendar.pm:22
>      perl(Data::ICal) - lib/Text/JSCalendar.pm:7
>      perl(Data::ICal::Entry::Alarm::Display) - lib/Text/JSCalendar.pm:11
>      perl(Data::ICal::Entry::Alarm::Email) - lib/Text/JSCalendar.pm:10
>      perl(Data::ICal::Entry::Event) - lib/Text/JSCalendar.pm:8
>      perl(Data::ICal::Entry::TimeZone) - lib/Text/JSCalendar/TimeZones.pm:22
>      perl(Data::ICal::Entry::TimeZone::Daylight) -
> lib/Text/JSCalendar/TimeZones.pm:23
>      perl(Data::ICal::Entry::TimeZone::Standard) -
> lib/Text/JSCalendar/TimeZones.pm:24
>      perl(MIME::Base64) - lib/Text/JSCalendar.pm:18
>      perl(URI::Escape) - lib/Text/JSCalendar.pm:21
>      perl(HTTP::Request) - t/cyrus-caldav.t:8
>      perl(lib) - t/cyrus-caldav.t:10
@@ -19,2 +19,11 @@
 # Run-time:
+BuildRequires:  perl(Carp)
+BuildRequires:  perl(Data::Dumper)
+BuildRequires:  perl(Data::ICal)
+BuildRequires:  perl(Data::ICal::Entry::Alarm::Display)
+BuildRequires:  perl(Data::ICal::Entry::Alarm::Email)
+BuildRequires:  perl(Data::ICal::Entry::Event)
+BuildRequires:  perl(Data::ICal::Entry::TimeZone)
+BuildRequires:  perl(Data::ICal::Entry::TimeZone::Daylight)
+BuildRequires:  perl(Data::ICal::Entry::TimeZone::Standard)
 BuildRequires:  perl(Data::ICal::TimeZone) >= 1.23
@@ -26,2 +35,3 @@
 BuildRequires:  perl(JSON::XS)
+BuildRequires:  perl(MIME::Base64)
 BuildRequires:  perl(MIME::Types)
@@ -29,3 +39,6 @@
 BuildRequires:  perl(Text::VCardFast) >= 0.06
+BuildRequires:  perl(URI::Escape)
 # Tests:
+BuildRequires:  perl(HTTP::Request)
+BuildRequires:  perl(lib)
 BuildRequires:  perl(LWP::UserAgent)
Ok

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2481488

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202481488%23c6

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to