https://bugzilla.redhat.com/show_bug.cgi?id=2463848
--- Comment #15 from Fabio Valentini <[email protected]> --- (In reply to blacknon from comment #12) > > > The remaining full build failure seems to come from Fedora’s packaged > > > compact_str 0.9.0 crate, which references ../README.md but does not ship > > > that file. > > > Would you prefer a temporary downstream workaround, or should this be > > > treated as a dependency-side issue first? > > > > Sorry, I don't understand. The package builds successfully. What do you > > mean to say here? > > Sorry, that wording was misleading. > > I was referring to Fedora's packaged `compact_str` crate, not to `hwatch` > itself. > For context, this came from a local Fedora package build test during the > `%build` phase of `rpmbuild -bb`, where Fedora's packaged `compact_str` > 0.9.0 failed to compile because `../README.md` was missing from > `/usr/share/cargo/registry/compact_str-0.9.0/`. Ok - this tells me that you used a non-standard build environment (i.e. not "mock"), probably some kind of container, where the RPM configuration prevents installation of files marked as "%doc". This does not affect package builds in Fedora (or COPR). We do consider this kind of issue to be a "packaging bug", but also treat it as very low priority since having the file marked as %doc only breaks things in non-standard build environments. > I've been making various modifications to the specs to circumvent this > issue, but what should I do this time? Don't. It's a non-issue for normal package builds. We only ever find out about this issue when users have non-standard build environments locally. :) > > 3. You're not handling licenses of statically linked dependencies at all. > > > > I would recommend to look at the template again, and / or at existing > > similar packages (for example, nushell). > > Thank you. > I changed now updated the `License:` field to reflect the statically linked > Rust dependencies and kept the bundled dependency license output in > `LICENSE.dependencies`. > > The above corrections have been applied to the following files. This is not really correct. In particular, clauses like "Apache-2.0 OR MIT" cannot just be collapsed into other "Apache-2.0"s and "MIT"s - the "OR" needs to be preserved. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2463848 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202463848%23c15 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
