https://bugzilla.redhat.com/show_bug.cgi?id=2463848
--- Comment #23 from [email protected] --- Thank you for the review. I updated packages. Spec URL: https://github.com/blacknon/hwatch/releases/download/0.4.2/hwatch-0.4.2-7.spec SRPM URL: https://github.com/blacknon/hwatch/releases/download/0.4.2/hwatch-0.4.2-7.src.rpm I updated the package to 0.4.2-7 and made the requested cleanups: - switched to `%bcond check 1` - removed unnecessary full command paths - simplified the `%check` command - cleaned up the install commands to use `install ... -t ...` For `rpmautospec`, I understand the recommendation, but I would prefer to keep the manual `Release` and `%changelog` handling for now. At this stage, I am making incremental updates in response to review feedback, and keeping explicit release numbers such as `0.4.2-6`, `0.4.2-7`, etc. makes those updates easier to track during the review. With `rpmautospec`, the release value follows the commit history, so multiple intermediate commits may advance the release number in a way that is less predictable for this review process. I may switch to `rpmautospec` later, but for now I would like to keep the current manual scheme until the review is finished. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2463848 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202463848%23c23 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
