https://bugzilla.redhat.com/show_bug.cgi?id=2449216



--- Comment #47 from Fabio Valentini <[email protected]> ---
Ok, using clang and LLD is fine if they're required to make the built library
work correctly.
But please document this in the .spec file (somewhere around `%global toolchain
clang`).

However, I'm not sure whether that's working correctly - I'm unsure whether the
packaged Rust toolchain calls gcc unconditionally or whether it actually looks
at the CC environment variable (or whatever it *should* look at).

That said: Make sure that the correct shared library is actually getting
installed, not only *built*.

For example, it looks like it is necessary to also have "export
LIBPATHRS_CAPI_BUILDMODE=cdylib" in %install (and possibly in %check too, for
consistency), otherwise "%cargo_cinstall" will recompile the library with the
wrong linker, and then install that broken file ... (cargo will recompile if
this environment variable changes between calls, due to
"println!("cargo:rerun-if-env-changed=LIBPATHRS_CAPI_BUILDMODE");" in
build.rs).


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2449216

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202449216%23c47

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to