https://bugzilla.redhat.com/show_bug.cgi?id=2465140
--- Comment #18 from Benson Muite <[email protected]> --- Almost there. Additional comments: a) Each of the changelog entries should have the release number, so instead of * Fri Mar 20 2026 Laurence Lundblade <[email protected]> - 1.6.1 use * Fri Mar 20 2026 Laurence Lundblade <[email protected]> - 1.6.1-1 b) Please also add a changelog entry for the current version of the spec file * Tue Jun 09 2026 Brian Sipos <brian.sipos at gmail dot com> - 1.6.1-2 - Initial import into Fedora c) Instead of (a) and (b) you could consider using %autochangelog and %autorelease macros, but this is not required. d) For the documentation please change install -m644 doxygen/docbook/*.xml -D -t %{buildroot}%{_docdir}/qcbor/docbook/ to install -m644 doxygen/docbook/*.xml -D -t %{buildroot}%{_datadir}/help/en/qcbor/ and %files doc %license LICENSE %{_docdir}/qcbor/ to %files doc %license LICENSE %doc %lang(en) %{_datadir}/help/en/qcbor/ e) Please change: Source0: %{url}/archive/refs/tags/v%{version}.tar.gz to Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz see: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags f) I have not used Tito, so do not know if there are things that need to be tweaked to work for different distributions that use spec files. It does seem useful, will examine it in future. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2465140 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202465140%23c18 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
