https://bugzilla.redhat.com/show_bug.cgi?id=2465140
Benson Muite <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #22 from Benson Muite <[email protected]> --- Comments: a) Thanks, one minor suggestion, either do not package the html documentation since this bundles extra javascript files, or if you do package it, place it in %{_docdir}/qcbor and possibly in a separate subpackage doc-html b) Use of the install command seems nicer: install -m644 doxygen/docbook/*.xml -D -t %{buildroot}%{_datadir}/help/en/qcbor/ but cp is also ok. If using cp, consider using cp -p -r to preserve timestamps. c) Approved. Consider making changes (a) and (b) before import. Thanks for bringing this to Fedora. d) Review of: https://bugzilla.redhat.com/show_bug.cgi?id=2487504 Would be appreciated if time allows. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2465140 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202465140%23c22 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
