https://bugzilla.redhat.com/show_bug.cgi?id=2386504
--- Comment #25 from Benson Muite <[email protected]> --- (In reply to Elaine Gibson from comment #24) > > Is the spec something that could be upstreamed? > > I can look at submitting a variant of it upstream. Does that affect the > Fedora packaging? > No, the spec used for packaging can be done independently. It may help reduce redundant work though and make package maintenance easier. > > Tests for the bundled lru-cache do not build > > Looks like it's due to -Werror? Remove -Werror from https://github.com/goldsborough/lru-cache/blob/master/tests/CMakeLists.txt#L5 Now get /builddir/build/BUILD/lru-cache-0_20170330git13f30ad-build/lru-cache-13f30ad33a227a3e9682578c450777380ecddfcf/include/lru/internal/base-ordered-iterator.hpp:128:12: error: use of deleted function ‘std::optional<LRU::Entry<const std::__cxx11::basic_string<char>, int> >& std::optional<LRU::Entry<const std::__cxx11::basic_string<char>, int> >::operator=(std::optional<LRU::Entry<const std::__cxx11::basic_string<char>, int> >&&)’ 128 | _entry = std::move(unordered_iterator._entry); | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /usr/include/gtest/internal/gtest-port.h:2388, from /usr/include/gtest/gtest-message.h:57, from /usr/include/gtest/gtest-assertion-result.h:46, from /usr/include/gtest/gtest.h:63, from /builddir/build/BUILD/lru-cache-0_20170330git13f30ad-build/lru-cache-13f30ad33a227a3e9682578c450777380ecddfcf/tests/iterator-test.cpp:26: /usr/include/c++/16/optional:810:11: note: ‘std::optional<LRU::Entry<const std::__cxx11::basic_string<char>, int> >& std::optional<LRU::Entry<const std::__cxx11::basic_string<char>, int> >::operator=(std::optional<LRU::Entry<const std::__cxx11::basic_string<char>, int> >&&)’ is implicitly deleted because the default definition would be ill-formed: 810 | class optional | ^~~~~~~~ /usr/include/c++/16/optional:810:11: error: use of deleted function ‘std::_Enable_copy_move<true, false, true, false, _Tag>& std::_Enable_copy_move<true, false, true, false, _Tag>::operator=(std::_Enable_copy_move<true, false, true, false, _Tag>&&) [with _Tag = std::optional<LRU::Entry<const std::__cxx11::basic_string<char>, int> >]’ In file included from /usr/include/c++/16/optional:50: /usr/include/c++/16/bits/enable_special_members.h:251:5: note: declared here 251 | operator=(_Enable_copy_move&&) noexcept = delete; | ^~~~~~~~ Note that the examples also do not build. Do you have any thoughts on: https://github.com/FreeCAD/FreeCAD/issues/30789 It is preferable to package lru-cache rather than bundle it, though it is likely one could also replace it with something else. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2386504 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202386504%23c25 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
