https://bugzilla.redhat.com/show_bug.cgi?id=2490673
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[email protected] |[email protected] Status|NEW |POST CC| |[email protected] Flags| |fedora-review+ --- Comment #5 from Fabio Valentini <[email protected]> --- Package looks good to me. There's one minor thing that you might want to address in some way (- or not): There are two files in the crate ( src/raw/tls/{mod.rs,thread_id.rs} ) that have "MIT OR Apache-2.0" license headers. It looks like they were included from a different project. If we assume that the upstream project wants to distribute the whole crate as just "MIT" and choose the "MIT" option for those two files - which I think is a reasonable deduction, since that *is* the license they set in Cargo.toml - then I think that should be fine and not require any changes downstream. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2490673 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202490673%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
