https://bugzilla.redhat.com/show_bug.cgi?id=2490673
--- Comment #6 from Ben Beasley <[email protected]> --- Thank you for the review! (In reply to Fabio Valentini from comment #5) > There's one minor thing that you might want to address in some way (- or > not): > > There are two files in the crate ( src/raw/tls/{mod.rs,thread_id.rs} ) that > have "MIT OR Apache-2.0" license headers. It looks like they were included > from a different project. If we assume that the upstream project wants to > distribute the whole crate as just "MIT" and choose the "MIT" option for > those two files - which I think is a reasonable deduction, since that *is* > the license they set in Cargo.toml - then I think that should be fine and > not require any changes downstream. Well spotted. It looks like these two files were originally derived from https://crates.io/crates/thread_local. There’s a good argument that the guidelines for filling the license field would like us to write “MIT AND (MIT OR Apache-2.0)” without any further analysis. Sadly, that would suggest that we ought to include a copy of the Apache-2.0 text as well. On the other hand, I agree that it’s pretty clear that upstream is just preserving the original attribution and copyright and license statement here, and intends to use them under the MIT option. After all, it’s not possible to compile a binary that only uses these two source files and doesn’t include any of the MIT-only sources. I also think it’s extremely unlikely that upstream would want to change the license to “MIT AND (MIT OR Apache-2.0)” or distribute an Apache-2.0 license text file. It therefore feels rather silly to go through the exercise of pedantically describing the Apache-2.0 option for these two files. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2490673 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202490673%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
