https://bugzilla.redhat.com/show_bug.cgi?id=2489821
--- Comment #7 from Martin Cermak <[email protected]> --- (In reply to Neal Gompa from comment #6) > More spec review: > > > Source0: > > https://fedorapeople.org/~mcermak/cow/archive/cow-%{vcshash}.tar.gz > > Please actually use the upstream source tarball generated by Codeberg. Your > own tarballs are not necessary. Upstream didn't release a tarball yet. So my own tarball is the only option for now. > It would look like this: > "%{url}/archive/%{vcshash}.tar.gz#/%{name}-%{vcshash}.tar.gz" > > > %autosetup -C -n cow-1.0 -p1 > > The "-n cow-1.0" is useless and should be dropped. "-C" supersedes it. > > > BuildRequires: libevent-devel > > Please use "pkgconfig(libevent)" since that's how meson.build pulls it in. > > > BuildRequires: pango-devel > > Please use "pkgconfig(pangocairo)" since that's how meson.build pulls it in. > > You also need to add a BR for "pkgconfig(cairo)" too. > > > Requires: libevent > > This is not needed, as RPM generates the required dependency automatically. Everything else addressed, I believe: https://fedorapeople.org/~mcermak/cow-package-review/iter_01/ Also, there's a copr build using this specfile: https://copr.fedorainfracloud.org/coprs/mcermak/cow/build/10617225/ Please review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2489821 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202489821%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
