https://bugzilla.redhat.com/show_bug.cgi?id=2463848
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(decathorpe@gmail. | |com) | --- Comment #33 from Fabio Valentini <[email protected]> --- The latest versions are better in some regards, but they also introduce quite a few *new* issues, and it currently doesn't even build. 1. You define "%bcond check 1" - this is superfluous with the "-t" flag for "%cargo_generate_buildrequires". You can replace this entire block: ``` %if %{with check} %cargo_generate_buildrequires -a -t %else %cargo_generate_buildrequires -a %endif ``` With just the standard "%cargo_generate_buildrequires -a". The macro reads the value of the "check" bcond, no need to pass the "-t" flag externally too. 2. The manual "cargo2rpm license-breakdown" calls are wrong. Not sure where you got this from: ``` # Keep a concrete dependency license manifest in the package, similar to helix. cargo2rpm --path Cargo.toml license-breakdown --all-features > LICENSE.dependencies test -s LICENSE.dependencies ``` helix does no such thing, it has "%{cargo_license} > LICENSE.dependencies". So in this case, this should probably just be: ``` %{cargo_license -a} > LICENSE.dependencies ``` 3. The arguments passed to "%cargo_test" are wrong - which makes the package currently fail to build. There's a missing second "--" before the "--skip" argument (yes, it needs two "--"). 4. The links used for Spec URL / SRPM URL don't lead to correctly named .spec and .src.rpm files, that's probably why they are not recognized by fedora-review-service. The file names should be "hwatch.spec" and "hwatch-9.4.2-9.fc45.src.rpm". 5. Not sure what these BuildRequires are for: "BuildRequires: bash-completion" - they should not be needed. 6. Use macros for the installation locations of shell completions: - %{bash_completions_dir} - %{fish_completions_dir} - %{zsh_completions_dir} -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2463848 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202463848%23c33 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
