https://bugzilla.redhat.com/show_bug.cgi?id=2463848
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(decathorpe@gmail. | |com) | --- Comment #37 from Fabio Valentini <[email protected]> --- Thanks, this looks pretty good now. I would leave making the positive review official to the original assignee. I am only curious why you are using a custom uploaded .tar.gz file / release asset, and not the autogenerated .tar.gz tarball? Usually the auto-generated tar.gz is preferable since it should correspond exactly to the contents of the repository, and is not handled through a separate (and often opaque / undocumented) release process. The relevant documentation for the "standard" way to reference tarballs for tags in a git repo hosted on GitHub is here: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags In this case, that would be: Source: %{url}/archive/0.4.3/hwatch-%{version}.tar.gz -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2463848 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202463848%23c37 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
