https://bugzilla.redhat.com/show_bug.cgi?id=2491110
--- Comment #3 from Chenxiong Qi <[email protected]> --- (In reply to Ankur Sinha (FranciscoD) from comment #2) > Looks very good. A few issues that are worth looking into: > > > - rpmlint flags: > > python-exa-py.src: W: summary-ended-with-dot Python SDK for Exa API. > python3-exa-py.noarch: W: summary-ended-with-dot Python SDK for Exa API. > 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 7 filtered, 0 > badness; has taken 0.6 s > > ^^^ > minor issue, please remove the period at the end of the summary Fixed. > > - Latest version is packaged. > ^^^ > The latest version is 2.14.0---we should be packaging this. This package is built because of building hermes-agent 0.14.0, that pins at exa-py 2.10.2. exa-py will be updated to newer version when building newer versions of hermes-agnet. > > - %check is present and all tests pass. > ^^^ > While the pypi tar does not include unit tests, the github tar does. I would > recommend using that and running the unit tests. > Upstream git repository does not have tag for version 2.10.2. This will be fixed along with building newer version of hermes-agent. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2491110 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202491110%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
