https://bugzilla.redhat.com/show_bug.cgi?id=2395643
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|[email protected] |[email protected] Flags| |fedora-review+ --- Comment #7 from Fabio Valentini <[email protected]> --- Package looks good to me! One thing that is a bit confusing is this change that you apply to Cargo.toml: """ - "LICENSE", + "/LICENSE", """ Both should do the same thing in this case, since there is only one file named "LICENSE" in the tarball? Upstream has also released 0.5.1 recently, it would be nice if you could update to that version. Looking at the diff from 0.5.0, it should be a straightforward backwards compatible update. === Package was generated with rust2rpm, simplifying the review. The downstream patches are well documented and justified. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass 🫤 latest version of the crate is packaged: version 0.5.0 is packaged, latest is 0.5.1 The difference looks very small, so this can just be updated after import. ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2395643 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202395643%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
