https://bugzilla.redhat.com/show_bug.cgi?id=2395643
--- Comment #9 from Aleksei Bavshin <[email protected]> --- Thanks for the review! (In reply to Fabio Valentini from comment #7) > Package looks good to me! > > One thing that is a bit confusing is this change that you apply to > Cargo.toml: > > """ > - "LICENSE", > + "/LICENSE", > """ > > Both should do the same thing in this case, since there is only one file > named "LICENSE" in the tarball? There's also %{_nginx_buildsrcdir}/LICENSE (BSD-3-Clause from the nginx sources) that will be picked by cargo install without the change. I'll add this to the patch comment. The change is not worth upstreaming, because it deals with the weirdness of %nginx_modconfigure macro implementation. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2395643 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202395643%23c9 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
