https://bugzilla.redhat.com/show_bug.cgi?id=2497737
Artur Frenszek-Iwicki <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #16 from Artur Frenszek-Iwicki <[email protected]> --- > BuildRequires: libappstream-glib This seems unused. > Requires: python3 > Requires: python3-mutagen > Requires: python3-qt5 > Requires: python3-semantic_version > Requires: python3-send2trash > Requires: python3-xxhash I'd argue these tags should be required on the python package, not the main package. > cat >%{name} <<EOF > #!/usr/bin/sh > exec /usr/bin/python3 /usr/share/dupeguru/run.py "$@" > EOF You should be able to use %{_bindir} and %{_sharedir} macroshere. rpmbuild will expand those while parsing the spec and cat will see only the expanded values. > %make_install NO_VENV=1 PREFIX=/usr > make installdocs NO_VENV=1 DESTDIR=%{buildroot} PREFIX=/usr You can use the %{_prefix} macro here. > install -m 755 %{name} %{buildroot}%{_bindir}/%{name} > install -m 644 -D README.md %{buildroot}%{_pkgdocdir}/README.md > install -m 644 help/changelog %{buildroot}%{_pkgdocdir}/changelog Use the -p option to preserve file timestamps. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2497737 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202497737%23c16 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
