https://bugzilla.redhat.com/show_bug.cgi?id=2497737



--- Comment #17 from Carl Byington <[email protected]> ---
Thanks for the comments - those are done.

I have been working on adding a top level dupeguru namespace to the python
code. This project was also much closer than I thought to a standard setuptools
build. The current .spec file uses 
%pyproject_buildrequires
%pyproject_wheel
%pyproject_install
%pyproject_save_files

In order to add the namespace, I think we need to move (core,hscommon,qt) down
one level in the file system tree, so the patch would be the same size as the
entire project. For now, that is done via commands in %setup, and two small
patches. All of that will eventually be changed to a pull request patch, but I
want to get feedback first confirming that this is the proper way to package
this.

With the addition of the namespace, the %pyproject_* packaging puts the python
code in %{python3_sitearch}/%{name}. At runtime, we are looking for the help/
and locale/ files in that same directory, but it seems those should be
installed into %{_datadir}/%{name}. I fixed this via two absolute symlinks from
%{python3_sitearch}/%{name} into %{_datadir}/%{name}. Is there a cleaner way to
do that?

[fedora-review-service-build]


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2497737

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202497737%23c17

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to