https://bugzilla.redhat.com/show_bug.cgi?id=2500937
Steve Cossette <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[email protected] |[email protected] CC| |[email protected] Status|NEW |ASSIGNED --- Comment #1 from Steve Cossette <[email protected]> --- Some early suggestions: 1- The versioning here seems wrong to me. You can find all of the possible use cases here: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ (OR at least most of them). In this case, following something similar to how I have done with fielding (https://src.fedoraproject.org/rpms/fielding/blob/rawhide/f/fielding.spec) might make this an easy fix. 2- The version in the history is wrong 3- Put %cmake_kf6 in the %conf section (See: https://docs.fedoraproject.org/en-US/packaging-guidelines/KDEPackaging/#_available_macros) -- that is a new directive btw. The %conf section should be put after %prep. 4- For the sake of consistency, BuildRequires: qt6-qtbase-devel BuildRequires: qt6-qtsvg-devel should be changed to BuildRequires: cmake(Qt6Core) BuildRequires: cmake(Qt6Svg) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2500937 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202500937%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
