https://bugzilla.redhat.com/show_bug.cgi?id=2500937
--- Comment #5 from Christopher Klooz <[email protected]> --- Optimized build at copr: https://copr.fedorainfracloud.org/coprs/py0xc3/kdominate/build/10737759/ > Remove %cmake_kf6 from the %build section Implemented > (This is your decision) Use the rpmautospec automatic changelog generator on > import I aim to use %autochangelog once everything has landed, but wanted to first find out how the system in general behaves before implementing this. Doing a step by step approach :) > Also, you should use `%find_lang %{name} --with-html` instead of the > `%{_kf6_datadir}/doc/HTML/en/kdominate` file listings. I was first confused by this point and how to link the first with the second part and with the existing "%find_lang %{name}" in the file. But it led to an interesting experience [1]. Thanks for it, implemented. --- [1] two potential suggestions to update the Docs: 1) I wonder if it's worth to add this to the docs page not yet containing "--with-html" (only other variants contained, like --with-gnome) for the sake of discoverability? 2) it might be worth to mention explicitly that "%find_lang %{name} --with-html" does contain "%find_lang %{name}". That saves some time, I had to run several builds to see what fails and what not to find out for sure :) Both not critical though! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2500937 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202500937%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
