https://bugzilla.redhat.com/show_bug.cgi?id=2506100
Hans de Goede <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Hans de Goede <[email protected]> --- Not a full review, but something I noticed on a first quick check: You set "License: MIT" in the .spec but the WHENCE file shows that all firmware files are actually under the LICENSE.qcom or LICENSE.qcom-2 licenses. Luckily those exact same license files (I checked) are also used in linux-firmware, so we don't need to go through a legal review for them, since Fedora already distributes firmware files under these licenses. Since the WHENCE file never references the MIT license at all I believe that the correct License tag is: License: LicenseRef-Callaway-Redistributable-no-modification-permitted as used for linux-firmware for all files not under GPL or MIT. With that resolved I believe these should fall under Fedora's standard firmware distribution rules, so it is allowed to actually package these. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2506100 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202506100%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
