https://bugzilla.redhat.com/show_bug.cgi?id=2506100
Hans de Goede <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[email protected] |[email protected] Flags| |fedora-review? | |needinfo?([email protected] | |ualcomm.com) --- Comment #3 from Hans de Goede <[email protected]> --- Thank you for working on this. I've done a full review and found a few small issues which need to be fixed: Must fix: - Please add a comment above the top block with the 4 %global-s disabling debuginfo and stripping explaining that this package only contains ELF binaries for hexagon DSPs and that these need to be disabled because the scripts try to operate on these binaries - Since this is not building any native binaries it should be noarch, please add "BuildArch: noarch" while keeping the ExclusiveArch line, this will build noarch packages but only add them to the aarch64 repos. - The Source0: URL gives a 404 error. Please fix and maybe consider using the %forge stuff like done in: https://src.fedoraproject.org/rpms/qdl/blob/rawhide/f/qdl.spec - Directories like /usr/share/hexagon-dsp/qcs6490 and /usr/share/hexagon-dsp/qcs6490/radxa and /usr/share/hexagon-dsp/qcs6490/Thundercomm are not owned by the subpackages using them, only the last component of the path is owned. This means that empty directories will stay around after uninstalling the package. I see that the last part of the path always consists of: <soc>/<board-vendor>/<model> maybe pass these as 3 different arguments to %boardfiles and add the upper directories to %files as e.g.: %dir %{_datadir}/hexagon-dsp/%{2} %dir %{_datadir}/hexagon-dsp/%{2}/%{3} %{_datadir}/hexagon-dsp/%{2}/%{3}/%{4} ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2506100 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202506100%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
