https://bugzilla.redhat.com/show_bug.cgi?id=2426937



--- Comment #16 from Artur Frenszek-Iwicki <[email protected]> ---
> License:        GPL-3.0-or-later AND BSD-3-Clause AND MIT AND ODbL-1.0
Please add a comment to the spec file, explaining the licensing breakdown.

> Source1:        LICENSE.BSD-3-Clause
> Source2:        LICENSE.MIT
These licenses could probably be extracted from the relevant files using some
awk trickery, but this is also okay.

> %{qmake_qt6} PREFIX=%{_prefix} -r %{_qt6_qmake_flags} QMAKE_CFLAGS+="-fPIC 
> -fPIE" QMAKE_CXXFLAGS+="-fPIC -fPIE" QMAKE_LFLAGS="${RPM_LD_FLAGS} -pie 
> -Wl,--as-needed"
Avoid mixing $RPM_ shell vars and %{macros}. You can use %{build_ldflags}
instead of $RPM_LD_FLAGS here.

> desktop-file-install --delete-original 
> --dir=%{buildroot}%{_datadir}/applications 
> %{buildroot}/%{_datadir}/applications/%{name}.desktop
If the desktop file is already installed by %make_install, you don't need to
run desktop-file-install separately.

> %files
> %{_datadir}/icons/hicolor/256x256/apps/%{name}.png
This necessitates "Requires: hicolor-icon-theme".


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2426937

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202426937%23c16

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to