https://bugzilla.redhat.com/show_bug.cgi?id=2426937
--- Comment #17 from Fabio Alessandro Locati <[email protected]> --- Thanks Artur, this is genuinely some of the most useful review feedback I've gotten on a package :). * License comment: Added a comment in the spec explaining the breakdown * RPM_LD_FLAGS: Switched to %{build_ldflags} * desktop-file-install: %make_install already installs the .desktop file, so removed the separate call * hicolor-icon-theme: Added Requires: hicolor-icon-theme Also bumped to the latest upstream release, 0.51.1. New version: Spec URL: https://fale.fedorapeople.org/qlog/qlog.spec SRPM URL: https://fale.fedorapeople.org/qlog/qlog-0.51.1-1.fc44.src.rpm Koji scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=148298668 Let me know if anything else needs fixing :). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2426937 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202426937%23c17 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
