https://bugzilla.redhat.com/show_bug.cgi?id=2503652
Hans de Goede <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? | |needinfo?([email protected] | |ualcomm.com) --- Comment #1 from Hans de Goede <[email protected]> --- Thank you for working on this. I've done a full review and found a few small issues which may need to be fixed: Must fix: - "%post" for the services should be "%post service" since the .service files are in the -service sub-package. - Same for %preun and %postun - "BuildRequires: systemd-units" should be "BuildRequires: systemd-rpm-macros" Maybe fix: - The service daemons seem to not depend on the libraries, so the: Requires: %{name}%{?_isa} = %{version}-%{release} in the -service subpackage seems unnecessary? Or do these get dl-opened? Maybe just add a duplicate %license line to the "%files service" and drop the Requires. - What is the common use-case of this. Do we expect most users to have the daemons installed ? And if yes do they then need the libraries at all? If the daemons are the common use-case maybe put them in the main package and add a -libs Might also be good to check what the Debian packages do here and mirror that. sub-package for the libs? (and make -devel depend on the -libs) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2503652 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202503652%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
