https://bugzilla.redhat.com/show_bug.cgi?id=2503652

Ali Erdinc Koroglu <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([email protected] |
                   |ualcomm.com)                |



--- Comment #2 from Ali Erdinc Koroglu <[email protected]> ---
Hello Hans,
Thanks for the review, new build includes the requested changes:

- %post / %preun / %postun are now scoped to the services sub-pkg
- BuildRequires: systemd-units -> systemd-rpm-macros

Yes, the daemons dlopen() their per-DSP listener library at runtime, therefore
I'd prefer to leave this explicit.
In the common use case the libraries are the primary consumer interface, so I'd
rather keep the *.so files in the main and the daemons+systemd files in
services package.
There's also no need to duplicate %license in the services sub-pkg since the
base package is guaranteed to be installed anyway.

Debian splits it almost the same way:
fastrpc-support: daemons + systemd files
libfastrpc1: shared libs
libfastrpc1-dev: headers and so symlinks


SPEC Url:
https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-aarch64/10774985-fastrpc/fastrpc.spec
SRPM Url:
https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-aarch64/10774985-fastrpc/fastrpc-1.0.6-1.fc45.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2503652

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202503652%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to