https://bugzilla.redhat.com/show_bug.cgi?id=2496893
--- Comment #8 from Dominik 'Rathann' Mierzejewski <[email protected]> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #7) > > %description > > Flare is an unofficial app that lets you chat with your friends on Signal > > from > > Linux. > Please add some meat to this. How does it relate to the official app? > Is it at feature parity? How is stability? > > > cat %{S:2} >> .cargo/config.toml > 'cp %{S:2} .cargo/config.toml' ? Changed. > Vendored sources are used. The guidelines say that this SHOULD NOT be done, > but in this case it's reasonable. Too many crates would need to be packaged > otherwise. Working on that in parallel at https://copr.fedorainfracloud.org/coprs/rathann/flare/ . > The vendor script doesn't work for me. > 'vendor/{winapi,windows}*/lib/*.{a,lib}' doesn't match anything. Not sure > how that happened. Fixed. > + package name is OK > (flare conflicts, flare-im is reasonable. > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/ > #_non_crate_rust_projects > seems to apply the best here, so "rust-" prefix should be used.) Not really. Non-crate.io applications must be named according to generic naming guidelines, "... i.e. they MUST NOT use a rust- prefix for the source package name." https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_package_naming_2 > - not the latest version. 0.21 is out. Please update. Updated to 0.22.0. [...] > rpmlint: > > flare-im.x86_64: W: no-manual-page-for-binary flare > OK :( > > > flare-im.spec: W: invalid-url Source1: flare-0.20.6-vendor.tar.bz2 > That is expected. > > > flare-im.x86_64: E: incorrect-locale-subdir > > /usr/share/locale/zh_Hans/LC_MESSAGES/flare.mo > > flare-im.x86_64: E: incorrect-locale-subdir > > /usr/share/locale/zh_Hant/LC_MESSAGES/flare.mo > > 2 packages and 0 specfiles checked; 2 errors, 2 warnings, 7 filtered, 2 > > badness; has taken 2.1 s > No idea what that means. I have some messages in that directory, > e.g. from dnf5. So maybe rpmlint is not up to date on locale names? No, this is correct. glibc has no notion of these locales. Fixed. > flare-engine has /usr/bin/flare. Either rename the binary (to flare-im?) > or add Conflicts. Added Conflicts. Spec URL: https://rathann.fedorapeople.org/review/flare-im/flare-im.spec SRPM URL: https://rathann.fedorapeople.org/review/flare-im/flare-im-0.22.0-2.fc45.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2496893 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202496893%23c8 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
