https://bugzilla.redhat.com/show_bug.cgi?id=2496893
Zbigniew Jędrzejewski-Szmek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #9 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- > Working on that in parallel at > https://copr.fedorainfracloud.org/coprs/rathann/flare/ . Nice! >> + package name is OK >> (flare conflicts, flare-im is reasonable. >> >>< https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/ >> #_non_crate_rust_projects >> seems to apply the best here, so "rust-" prefix should be used.) > Not really. Non-crate.io applications must be named according to generic > naming guidelines, Yeah, that's what I meant. I lost "not" in the last sentence, but the whole rest of the text was to justify that the name is appropriate. > Spec URL: https://rathann.fedorapeople.org/review/flare-im/flare-im.spec That still says 0.20.6 :( But the srpm has the update version, so I'm reviewing that. + package name is OK + latest version (0.22.0) + license is specified correctly (it's autogenerated, so I hope it's OK ;)) + license is acceptable for Fedora (AGPL-3.0-or-later is probably the strictest, but that is still allowed.) + standard Rust packaging is used + BR look reasonable, P/R are autogenerated + package builds fine in mock + minimal %check is present. The required check for the desktop file is done. Package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2496893 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202496893%23c9 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
