https://bugzilla.redhat.com/show_bug.cgi?id=2407352
--- Comment #8 from [email protected] --- (In reply to Artur Frenszek-Iwicki from comment #7) > > Provides: python-headset-battery-indicator = %{version} > This should include the Release number, as well. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or- > replacing-existing-packages > > > %post > > update-desktop-database &> /dev/null || : > > touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : > > gtk-update-icon-cache %{_datadir}/icons/hicolor &> /dev/null || : > > > > %postun > > update-desktop-database &> /dev/null || : > > gtk-update-icon-cache %{_datadir}/icons/hicolor &> /dev/null || : > These are not needed since at least Fedora 30. Fixed both issues raised in the previous review: 1. `Provides` now includes the Release number: `Provides: python-headset-battery-indicator = %{version}-%{release}` 2. Removed the `%post` and `%postun` scriptlets (`update-desktop-database`, `gtk-update-icon-cache`) along with their associated `Requires(post)` and `Requires(postun)` entries — no longer needed since Fedora 30. Successful Copr build on Fedora 42, 43, 44 and rawhide: https://copr.fedorainfracloud.org/coprs/ruflas/headset-battery-indicator/build/10775090/ SPEC URL: https://raw.githubusercontent.com/ruflas/headset-battery-indicator/main/headset-battery-indicator.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ruflas/headset-battery-indicator/srpm-builds/10775090/headset-battery-indicator-2.3.1-1.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2407352 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202407352%23c8 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
