https://bugzilla.redhat.com/show_bug.cgi?id=2407352



--- Comment #14 from Juan Jose Vazquez Prieto <[email protected]> ---
(In reply to Artur Frenszek-Iwicki from comment #13)
> > install -Dm0644 headset-battery-indicator.png \
> >     
> > %{buildroot}%{_datadir}/icons/hicolor/512x512/apps/headset-battery-indicator.png
> Add -p here to preserve the file timestamp.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps
> 
> > %files
> > %{_datadir}/icons/hicolor/512x512/apps/headset-battery-indicator.png
> This necessitates "Requires: hicolor-icon-theme".

Fixed both issues from comment #13:

Added -p to install -Dpm0644 to preserve the file timestamp, per Fedora
packaging guidelines.
Added Requires: hicolor-icon-theme since the package installs a file into the
hicolor icon directory.
Bumped to 2.3.1-2.

SPEC URL:
https://raw.githubusercontent.com/ruflas/headset-battery-indicator/main/headset-battery-indicator.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/ruflas/headset-battery-indicator/srpm-builds/10802458/headset-battery-indicator-2.3.1-2.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2407352

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202407352%23c14

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to