https://bugzilla.redhat.com/show_bug.cgi?id=2502852
--- Comment #3 from Steve Traylen <[email protected]> --- > %{!?sources_gpg: %{!?dlrn:%global sources_gpg 1} } What is "dlrn" - when would this be set ? > flake8-import-order has been excluded as a BR but it was never present in the first place ? > BuildRequires: pyproject-rpm-macros This is not needed - it is already part of the koji buildroot for fedora (and EPEL ) > sed -i /^minversion.*/d tox.ini This is redundant really , there is no need to remove that constraint and it us useful moving forward. > %if ! 0%{?with_doc} > %global excluded_brs %{excluded_brs} sphinx openstackdocstheme > %endif This is not needed , there is already a with_doc condition on the %tox macro and those deps are not included when `-e %{default_toxenv}` is used with docs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2502852 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202502852%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
