https://bugzilla.redhat.com/show_bug.cgi?id=2513914



--- Comment #3 from Benson Muite <[email protected]> ---
Initial comments:

a) Please change:

BuildRequires:  python3-devel
BuildRequires:  python3dist(networkx)
BuildRequires:  python3dist(numpy) >= 1.11
BuildRequires:  python3dist(scipy)
BuildRequires:  python3dist(setuptools)
BuildRequires:  python3dist(si

to

BuildRequires:  python3-devel
BuildRequires:  python3dist(pytest)


Other requirements will be automatically generated.

b) Please remove:
Requires:       python3dist(networkx)
Requires:       python3dist(numpy) >= 1.11
Requires:       python3dist(scipy)
Requires:       python3dist(setuptools)
Requires:       python3dist(six)

these will be automatically generated

c) Please change:
%pyproject_save_files geometric

to

%pyproject_save_files -L geometric

so get an error if license  is included automatically

d) Consider packaging docs and examples as a separate subpackage


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2513914

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202513914%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to