https://bugzilla.redhat.com/show_bug.cgi?id=2513914
--- Comment #8 from Susi Lehtola <[email protected]> --- (In reply to Cristian Le from comment #7) > > The packaging guidelines > > https://docs.fedoraproject.org/en-US/packaging-guidelines/ still state > > > As an alternative to the usual %setup macro, the %autosetup can be used. > > There is no realistic reason why not to use `%autopatch` (and `%autosetup` > being just the combination of them). I have hit numerous times when a PR > adds a patch and everyone forgets that it does not have an `%autopatch` and > it is silently a no-op just to come back months later confused why it is > still a problem. rpm issues a warning if there are patches that haven't been applied, this has never been an issue for me working 10+ years in Fedora. > Be kind to the fellow contributors and use the > `%autopatch`, or elaborate on why you do not like it. The reason why I dislike autopatch is that IIRC it is incompatible with fixing build failures. Updates to packages often lead to patches not applying; in the trivial case you just need to apply the patch manually as patch -p1 which is more robust about the development. Otherwise, I go in, adapt and put in the rejected changes, and regenerate the patch. This requires backups of the files with a known suffix. rpm documentation on autosetup and autopatch simply states -b (for creating patch backups) is accepted but currently ignored - this is not meaningful for a full-blown VCS anyway. If you need backups for gendiff use, use gendiff backend. So, in short, I don't remember having forgotten once to apply a patch in a production build, since rpm warns about it. In contrast, the suggested alternative basically has no documentation, and doesn't appear to implement basic functionality necessary for patch management. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2513914 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202513914%23c8 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
