https://bugzilla.redhat.com/show_bug.cgi?id=2510861
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #10 from Fabio Valentini <[email protected]> --- Just a few drive-by comments (not committing to a full review): - Don't use "if fedora else <...>" conditionals. This is a package under review *for Fedora*, the "else" condition would be dead code. - Missing documentation for which licenses apply to what (this project / vendored dependencies / etc.). This would usually be handled by the %cargo_license_summary and %cargo_license macros. "GPL-2.0-or-later AND MIT AND Apache-2.0" is not the correct / complete License tag, it needs to cover all items from the summary printed during the build: ### BEGIN LICENSE SUMMARY ### # Apache-2.0 OR MIT # Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT # BSD-2-Clause OR Apache-2.0 OR MIT # GPL-2.0-or-later # MIT # MIT OR Apache-2.0 # MIT OR Apache-2.0 OR LGPL-2.1-or-later # MIT OR LGPL-3.0-or-later # Unlicense OR MIT ### END LICENSE SUMMARY ### - Why use "Epoch: 1"? This is a new package, it should not need an Epoch yet. - Why use vendored dependencies? Fedora packages "SHOULD NOT" use vendored dependencies, unless adding required dependencies to Fedora would require an unreasonable amount of work. If you argue for "unreasonable amount of work", then that needs to be documented. - Use rpmautospec (%autorelease / %autochangelog). This is a "SHOULD" guideline too. In general, I would recommend that you look at the "non-crate Rust package" template, and the Rust packaging Guidelines in general: https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_non_crate_rust_project -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2510861 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202510861%23c10 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
